aherbert commented on a change in pull request #35: [CODEC-280] Added strict
decoding property to BaseNCodec.
URL: https://github.com/apache/commons-codec/pull/35#discussion_r370961690
##########
File path: src/test/java/org/apache/commons/codec/net/BCodecTest.java
##########
@@ -157,6 +158,7 @@ public void testDecodeObjects() throws Exception {
}
@Test
+ @Ignore("CODEC-280: Disabled strict decoding by default. The BCodec uses
the default so this test does not fail the impossible cases.")
Review comment:
Hi @garydgregory
I received an email from github with another comment from you but cannot
find it through the web interface so I'll repeat for clarity the comment was
"I'm all for making Base32 and Base64 carry the same option."
This PR already has the public setStrictDecoding(boolean) for Base32 and
Base64. The unresolved is whether the property should be added to BCodec as
well. At the moment this test is ignored because BCodec cannot be made strict.
So either:
1. Drop the test and BCodec is always lenient
2. Make BCodec always strict (this test will pass)
3. Make BCodec have configurable strict/lenient decoding
My option would be number 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
