[
https://issues.apache.org/jira/browse/GEOMETRY-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028102#comment-17028102
]
Matt Juntunen commented on GEOMETRY-75:
---------------------------------------
Thanks for the code review, [~aherbert]!
{quote}From what I know the computation takes about 75% of its runtime or more
for the over/underflow protection. Do you need to have this functionality?
{quote}
It has been requested in GEOMETRY-50.
{quote}I note that your benchmarks use 1 vector. Best practice for benchmarking
code with lots of branches is to have a lot of data.
{quote}
I've updated it to use a list of input vectors, 1000 by default. I used the
approach given in the JMH examples
[here|https://hg.openjdk.java.net/code-tools/jmh/file/a61ab96aafb9/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_34_SafeLooping.java]
and directed the output to a {{Blackhole}}.
bq. In the Complex benchmark I have added unnormalized vectors using a
NormalizedGaussianSampler for each dimension. ... It applies perfectly to what
you are benchmarking here.
I added it in and I hope I'm using it correctly. The result numbers seem to be
about the same.
> Performance Test Module
> -----------------------
>
> Key: GEOMETRY-75
> URL: https://issues.apache.org/jira/browse/GEOMETRY-75
> Project: Apache Commons Geometry
> Issue Type: Task
> Reporter: Matt Juntunen
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add a module for executing performance tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
