[
https://issues.apache.org/jira/browse/COMPRESS-503?focusedWorklogId=382147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382147
]
ASF GitHub Bot logged work on COMPRESS-503:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/20 08:40
Start Date: 05/Feb/20 08:40
Worklog Time Spent: 10m
Work Description: coveralls commented on issue #92: COMPRESS-503 : "open
when actually needed" for MultiReadOnlySeekableByteChannel
URL: https://github.com/apache/commons-compress/pull/92#issuecomment-582299600
[](https://coveralls.io/builds/28537848)
Coverage decreased (-0.2%) to 86.754% when pulling
**7ffc7a87236be2fd72b663f2735370a2d183494a on
PeterAlfreadLee:COMPRESS-477-improve** into
**151e0fb3fa241887ae3192cc92c572401c6a182b on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 382147)
Remaining Estimate: 0h
Time Spent: 10m
> "open when actually needed" for MultiReadOnlySeekableByteChannel
> ----------------------------------------------------------------
>
> Key: COMPRESS-503
> URL: https://issues.apache.org/jira/browse/COMPRESS-503
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Peter Alfred Lee
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When I was adding zip64 support for split zip, I encountered a problem :
> When adding testcases in {{Zip64SupportIT}}, I created a split zip with
> 10,000+ split segments. Then I found that I was unable to unzip it because
> there would be too many open files when extracting it. We can oepn the files
> when actually needed and therefore we can successfully extract such split
> zips with great amount of segments.
> I have set a threshold of 20 in {{MultiReadOnlySeekableByteChannel}}. The
> "open when actually needed" procedure will only work when the number of split
> segments is greater than the threshold.
>
> This may be used in ZipArchiveInputStream and ZipFile cause
> {{MultiReadOnlySeekableByteChannel}} is used in them.
>
> Actually this is a pretty rare case cause most split zips would not have too
> many segments. Just thinking about a split zip with 1,000+ segments - it must
> be a nightmare. So I'm not sure if this is needed for
> {{MultiReadOnlySeekableByteChannel.WDYT?}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
