[ 
https://issues.apache.org/jira/browse/VFS-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037913#comment-17037913
 ] 

Woonsan Ko commented on VFS-758:
--------------------------------

I think this will be fixed by https://github.com/apache/commons-vfs/pull/83.

Basically this issue was caused by the hard-coded "http" in 
{{Webdav4FileObject#toUrlString(GenericURLFileName, boolean)}}, by which some 
webdav specific http invocation is done by resolving "internal" http(s) urls.
As all {{Http4FileObject}} objects have an internally-resolved URLs, converted 
from logical url names to physical ones, the code should have simply used 
{{#getInternalURI().getScheme()}} instead of the hard-coded one.
I've also added unit tests for the simple http/https url checking in http4, 
http5 and webdav4.

Regards,

Woonsan

> Webdav4s provider does not make https requests
> ----------------------------------------------
>
>                 Key: VFS-758
>                 URL: https://issues.apache.org/jira/browse/VFS-758
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Woonsan Ko
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Reported by https://github.com/ddg-igh:
> - https://github.com/apache/commons-vfs/pull/81
> {quote}
> When using webdav4s the requests will be send as "http" and not "https".
> So this will always fail when the webdav server does not allow "http" 
> requests."
> {quote}
> I was also able to reproduce through shell:
> {noformat}
> $ cd commons-vfs2-examples
> $ mvn -Pshell -Dwebdav4
> VFS Shell null
> cd webdav4s://localhost
> Command failed:
> ...
> Caused by: org.apache.http.conn.HttpHostConnectException: Connect to 
> localhost:80 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: 
> Connection refused (Connection refused)
> ...
> {noformat}
> - which shows that it makes http request at port 80, not 443.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to