garydgregory commented on issue #58: export page data from db URL: https://github.com/apache/commons-csv/pull/58#issuecomment-590021088 > > intent > > > This ticket has no description so I have no idea what the intent is here. The lack of Javadoc does not help either. > > you can see the method DbQueryExportTest.testExport(), this test method will export querying page data from db @shootercheng I'm sorry so say that you're not helping your PR here :-( You should provide some kind of description for this PR so that people can learn what problem this PR attempts to solve and how. This would then allow reviewers to try to understand if this code belongs here and how it can fit in. I suppose you could fill in the Javadoc at a later phase of your development (but before any merge into Commons CSV.) If you want to export database rows, you can use `org.apache.commons.csv.CSVPrinter.printRecords(ResultSet)` which works with Java's own JDBC framework. The printer class also provides other types of services to create CSV files. More importantly, I see zero reuse of Commons CSV's code for which this PR seems to duplicate features like using your `ExportParam` instead of CVS's `CSVFormat`. It seems this PR is complete;y standalone code from Commons CSV since it does not reuse any of Commons CSV's code. Why would it belong within Commons CSV?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
