sgoeschl commented on a change in pull request #60: Fix csv 149 195 URL: https://github.com/apache/commons-csv/pull/60#discussion_r383817436
########## File path: src/test/java/org/apache/commons/csv/CSVParserTest.java ########## @@ -1281,4 +1283,37 @@ private void validateRecordPosition(final String lineSeparator) throws IOExcepti parser.close(); } + + @Test + public void parseIssue195andIssue149() throws IOException { + String records = "A,B,C,D\r\n" + + "a1,b1,c1,d1\r\n" + + "a2,b2,c2,d2"; + CSVFormat format = CSVFormat.RFC4180; + format = format.withFirstRecordAsHeader(); + format = format.withIgnoreEmptyLines(); + format = format.withTrim(); + format = format.withQuote('"'); + CSVParser parser = format.parse(new StringReader(records)); Review comment: Maybe " try-with-resources" instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services