dota17 commented on issue #5: Fix eol checking for read array in 
ExtendedBufferedReader
URL: https://github.com/apache/commons-csv/pull/5#issuecomment-592290185
 
 
   hi @britter after review the code,I think what @mirasrael means is that when 
use a new char[] buf and  offset start from 5 in that way buf[0] to buf[4] are 
unspecified. so when i equals offset (that means i is 5)  the  expression  (i > 
0 ? buf[i - 1] : lastChar return buf[4]  but what should return lastChar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to