nhojpatrick commented on issue #39: CODEC-285 upgrade to JUnit v5.6.0 URL: https://github.com/apache/commons-codec/pull/39#issuecomment-593420212 > When including multiple JUnit dependencies I would use the JUnit BOM in the dependency management to ensure they are kept in sync: > > ``` > <dependency> > <groupId>org.junit</groupId> > <artifactId>junit-bom</artifactId> > <version>X.Y.Z</version> > <scope>import</scope> > <type>pom</type> > </dependency> > ``` > > I'd like to highlight that codec targets JDK 7. These changes to the build tools would prevent building on JDK 7. I'm fine with forcing JDK 8+ for the toolchain but Java 7 still has support until July 2022 and someone may care about this. if i can upgrade all the tests quick enough, junit-vintage-engine will be going asap, so i would prefer to keep both separately defined so i can start moving tests from vintage to jupiter, then another future to drop junit-vintage-engine. i agree long term it would be better to define to keep in sync but depending how long the discussions are, depends how long you have duplicate definitions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
