[
https://issues.apache.org/jira/browse/MATH-1525?focusedWorklogId=405252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405252
]
ASF GitHub Bot logged work on MATH-1525:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/20 07:28
Start Date: 18/Mar/20 07:28
Worklog Time Spent: 10m
Work Description: aherbert commented on issue #126: #MATH-1525 Move out
"EmptyClusterStrategy" from KMeansPlusPlusClusterer
URL: https://github.com/apache/commons-math/pull/126#issuecomment-600466181
A commit is missing. Did you force push on your branch or on a branch this
is based on?
However there is also this error:
```
[ERROR]
/home/travis/build/apache/commons-math/src/main/java/org/apache/commons/math4/ml/clustering/extractor/FarthestPointExtractor.java:[66,47]
getCenter() is not public in
org.apache.commons.math4.ml.clustering.CentroidCluster; cannot be accessed from
outside package
```
Given that this is true (the method is package private), this PR will always
fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 405252)
Time Spent: 20m (was: 10m)
> The "EmptyClusterStrategy" in KMeansPlusPlusClusterer should be move out as a
> Interface
> ---------------------------------------------------------------------------------------
>
> Key: MATH-1525
> URL: https://issues.apache.org/jira/browse/MATH-1525
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Chen Tao
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The "EmptyClusterStrategy" and relative code in KMeansPlusPlusClusterer
> should be move out as a Interface and different implementations.
> The can be reused in other Cluster algorithms, such as
> MiniBatchKMeansClusterer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)