[
https://issues.apache.org/jira/browse/LANG-1519?focusedWorklogId=407636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407636
]
ASF GitHub Bot logged work on LANG-1519:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/20 17:49
Start Date: 22/Mar/20 17:49
Worklog Time Spent: 10m
Work Description: garydgregory commented on issue #495: LANG-1519 Add
zero, positive & negative util methods
URL: https://github.com/apache/commons-lang/pull/495#issuecomment-602246497
@nnivruth ,
Thank you for your updates. The code covers all the cases it seems which is
nice. The drawback ATM is that it does not feel very OO. I am wondering if all
of this could be implemented in terms of a new utility method called
compare(Number, Number) which would allow the isZero, isPositive and isNegative
to be implemented by calling compare(aNumber, ZERO). More thinking and
experimenting needed...
This is all non-trivial, so I think I might cut a 3.10 RC which I am late on
and this PR would end up in 3.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 407636)
Time Spent: 5h 10m (was: 5h)
> Add Integer Utils to library
> ----------------------------
>
> Key: LANG-1519
> URL: https://issues.apache.org/jira/browse/LANG-1519
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
> Reporter: Nivruth Nandigam
> Priority: Trivial
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Create Integer Utils class for useful integer operations and a placeholder
> for adding more useful/important utility functions
>
> Pull Request: [https://github.com/apache/commons-lang/pull/495]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
