[
https://issues.apache.org/jira/browse/COLLECTIONS-754?focusedWorklogId=411613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411613
]
ASF GitHub Bot logged work on COLLECTIONS-754:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/20 04:54
Start Date: 28/Mar/20 04:54
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #136: COLLECTIONS-754
upgrade to JUnit v5.6.0
URL:
https://github.com/apache/commons-collections/pull/136#discussion_r399619816
##########
File path: pom.xml
##########
@@ -445,9 +445,27 @@
<dependencies>
<dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>5.6.0</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <version>5.6.0</version>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest</artifactId>
+ <version>2.2</version>
Review comment:
If this PR gets merged, then #135 doesn't need to be merged I guess? In that
case, we could maybe close that other PR and leave just this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 411613)
Remaining Estimate: 0h
Time Spent: 10m
> Upgrade to JUnit v5.6.0
> -----------------------
>
> Key: COLLECTIONS-754
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-754
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: John Patrick
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As Per Email 2020/03/01 11:07, "Java Modules Codec, Collections, IO and
> Lang", and
> https://github.com/apache/commons-collections/blob/master/CONTRIBUTING.md.
> Step 3, update to junit v5.6 (jupiter and vintage)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
