aherbert commented on a change in pull request #108: Refactor ByteArrayOutputStream into synchronized and non-synchronized versions URL: https://github.com/apache/commons-io/pull/108#discussion_r402927109
########## File path: pom.xml ########## @@ -226,6 +230,11 @@ file comparators, endian transformation classes, and much more. </contributors> <dependencies> + <dependency> + <groupId>com.google.code.findbugs</groupId> + <artifactId>jsr305</artifactId> Review comment: Is this just to bring in the @javax.annotation.concurrent.ThreadSafe annotation? I don't think this necessary since you already document the thread safety in the javadoc. Nothing else in the code base uses this non-standard annotation support. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
