garydgregory commented on issue #108: Refactor ByteArrayOutputStream into synchronized and non-synchronized versions URL: https://github.com/apache/commons-io/pull/108#issuecomment-608587144 > @garydgregory Okay I understand. Your preferred option is very long though. How do you feel about: > > 1. `UnsyncByteArrayOutputStream`. The least worst IMO. > 2. `UByteArrayOutputStream`. Oh, the horror! ;-) There is no convention that equates "U" to "Unsynchronized", if anything "U" usually stands for "Unsigned". > 3. `USByteArrayOutputStream`. Even worse IMO! Same comment as above except US usually means... United States? > 4. `UnsafeByteArrayOutputStream`. Nope, same as for "Fast", unsafe compared in what area? Will this be a CVE? I do not thing there should be an issue spelling out Unsynchronized, if you look around, you'll see similar names spelled out: - javax.transaction.Synchronization - java.util.concurrent.locks.AbstractOwnableSynchronizer - java.util.concurrent.locks.AbstractQueuedLongSynchronizer - java.util.concurrent.locks.AbstractQueuedSynchronizer - java.util.Collections.SynchronizedCollection - java.util.Collections.SynchronizedList - java.util.Collections.SynchronizedMap - java.util.Collections.SynchronizedNavigableMap - java.util.Collections.SynchronizedNavigableSet - java.util.Collections.SynchronizedRandomAccessList - java.util.Collections.SynchronizedSet - java.util.Collections.SynchronizedSortedMap< - java.util.Collections.SynchronizedSortedSet - Too many to list in Google Guava. - Too many to list in our own Apache Commons Collections. So, IMO, just say what it does.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
