gwlucastrig commented on issue #72: IMAGING-251 support for TIFF floating-point formats URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-609754793 I've pushed the checkstyle fixes up to my branch. Let me know if any further action is required on my part. I am continuing to work toward completing the changes for the issue. As a side effect, these changes may eventually address Issue 102. Gary On Mon, Apr 6, 2020 at 6:21 AM Gary Lucas <[email protected]> wrote: > Thanks for the information. It clarifies some of the confusing area of > submitting a pill request. I have been using git for about a year now, but > still don't understand the underlying logic of the system. > > > On Sun, Apr 5, 2020, 6:20 PM Bruno P. Kinoshita <[email protected]> > wrote: > >> I ran check style and see that I introduced tabs and trailing spaces. >> Serves me right. I turned off the auto-format in my IDE because I didn't >> want to introduce white-space changes to existing code. I ran checkstyle >> from Maven using "mvn checkstyle:checkstyle". Is that the command the >> project recommends? >> >> You can run just mvn as Commons Imaging has a default Maven goal in its >> pom.xml. That's how Travis does it >> <https://github.com/apache/commons-imaging/blob/1397ca92cd3268b434ad8a18529ee3544bbcf3c5/.travis.yml#L32> >> too. >> >> Some developers are able to integrate the checkstyle rules in their >> IDE's. I am a bit behind the time, and still use the command line for most >> things. So my workflow is normally to change the files, have a look at the >> IDE warnings (Eclipse), then mvn and prepare a commit (i.e. run tests >> and some other checks). >> >> Doesn't work every time as I can forget to run it too :) >> >> What should I do to address this? Submit a new PR? >> >> In your branch you should be able to resolve the style issues, by editing >> the files Travis is showing with errors. Then run mvn and once it passes >> prepare a new commit and push to your fork. >> >> After this, this pull request should be automatically updated. >> ------------------------------ >> >> If you look near the PR title, where it says "gwlucastrig wants to merge >> 1 commit into...", you should see that this PR is supposed to merge code >> into apache:master. >> >> But I can see you didn't use a branch in your fork, as it says that it >> would merge it from "gwlucastrig:master". It will work fine. But now this >> PR is "linked" to your branch master on your fork. >> >> Which means that if you start working on another issue, and you push to >> your master branch, that would update this PR as well. >> >> Furthermore, once it's merged, you may have to use something like git >> reset --hard to sync your fork again. >> >> For that, I always start new work with git checkout -b name-of-my-branch >> (where normally I have name-of-my-branch as something like IMAGING-123, >> or fix-color-palette-8-bits-etc. >> >> That way I am able to work on multiple issues 👍 just a note, as we >> should be able to work on IMAGING-251 just fine this way, but just in case >> you want to work on multiple issues, then having branches and not using >> master in your fork might be helpful. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/commons-imaging/pull/72#issuecomment-609494043>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AEWJDYIDN44BQ4HSOQDNCB3RLD7Z5ANCNFSM4MAWGVRQ> >> . >> >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
