garydgregory commented on issue #108: Refactor ByteArrayOutputStream into 
synchronized and non-synchronized versions
URL: https://github.com/apache/commons-io/pull/108#issuecomment-610479408
 
 
   > @garydgregory Hmm, from what I read in coveralls.io the code coverage 
after this PR is `+0.07%` so it is a net improvement, no?
   
   Please run the command I provided and look at the JaCoCo report. You will 
see that the new class has less coverage than the current (refactored) one. We 
should strive to give the best possible code coverage for changes and new code.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to