garydgregory commented on issue #111: [IO-661] FileUtils throws inconsistent exceptions URL: https://github.com/apache/commons-io/pull/111#issuecomment-615500548 -1: The approval (@michael-o) was premature since the build fails making this PR incomplete and not acceptable as is :-( Changing the thrown exceptions requires the tests to match; authors (@ferenc-csaky), please run a local build before committing. While the method signatures have not changed (we keep binary compatibility), the behavior has changed, this needs more thought IMO. We need to really be sure that for each method, we document the changes in https://issues.apache.org/jira/browse/IO-661. The Javadoc has been updated so that's good. We also need to convince ourselves that it is OK to break some call sites with this change. I am not convinced yet.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
