kinow commented on issue #515: Remove unnecessary unboxing in BooleanUtils. URL: https://github.com/apache/commons-lang/pull/515#issuecomment-615512356 > -1 from my POV. In a low-level library like Commons Lang we should make explicit where we mix primitives and Objects. I want to be made aware of where the boxing and unboxing do in fact take place, which will have consequences depending on some use cases. Boxing is not just syntactical sugar. I thought that would be OK given we were checking for `null` in all the cases, but agree on the part about being a low level library and being explicit on primitive vs. Object.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
