[
https://issues.apache.org/jira/browse/COLLECTIONS-760?focusedWorklogId=424965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424965
]
ASF GitHub Bot logged work on COLLECTIONS-760:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/20 23:34
Start Date: 18/Apr/20 23:34
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #149:
[COLLECTIONS-760]: Add tests for MapUtils
URL:
https://github.com/apache/commons-collections/pull/149#discussion_r410769983
##########
File path: src/test/java/org/apache/commons/collections4/MapUtilsTest.java
##########
@@ -56,6 +58,7 @@
*/
@SuppressWarnings("boxing")
public class MapUtilsTest extends AbstractAvailableLocalesTest {
+ private static final String THREE = "Three";
Review comment:
Hi @Isira-Seneviratne should we have constants for "Two", and "key"? As this
is a test class, I think we can have it either way, with or without constants,
as the class size is not huge as well. Up to you :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424965)
Remaining Estimate: 0h
Time Spent: 10m
> Add tests for MapUtils
> ----------------------
>
> Key: COLLECTIONS-760
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-760
> Project: Commons Collections
> Issue Type: Improvement
> Affects Versions: 4.4
> Reporter: Bruno P. Kinoshita
> Assignee: Bruno P. Kinoshita
> Priority: Minor
> Fix For: 4.5
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Placeholder for https://github.com/apache/commons-collections/pull/149
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
