kinow edited a comment on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615985425 > I'd be better to have .gitattributes to handle such cases... Hi @michael-o good point, [lang] already has one. I never added one to an existing project. I tried dropping the current commit, and adding the `.gitattributes` from [lang], but running `mvn` checkstyle complained again about CRLF. Are the changes applied only after cloning the repository? Or do we actually need both, the commit converting files to unix, and the `.gitattributes` to ensure future commits are automatically converted to LF by git? (I'm guessing the latter)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
