[
https://issues.apache.org/jira/browse/COLLECTIONS-759?focusedWorklogId=424972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424972
]
ASF GitHub Bot logged work on COLLECTIONS-759:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/20 00:04
Start Date: 19/Apr/20 00:04
Worklog Time Spent: 10m
Work Description: kinow commented on issue #147: [COLLECTIONS-759]: add
newline at end of file, and convert to unix (LF instead of CRLF) fixing
checkstyle
URL:
https://github.com/apache/commons-collections/pull/147#issuecomment-615985425
> I'd be better to have .gitattributes to handle such cases...
Thanks @michael-o good point, [lang] already has one. I never added one to
an existing project. I tried dropping the current commit, and adding the
`.gitattributes` from [lang], but running `mvn` checkstyle complained again
about CRLF.
Are the changes applied only after cloning the repository? Or do we actually
need both, the commit converting files to unix, and the `.gitattributes` to
ensure future commits are automatically converted to LF by git? (I'm guessing
the latter)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424972)
Time Spent: 1h (was: 50m)
> An issue about the failed with CI about the checkstyle of NewlineAtEndOfFile.
> -----------------------------------------------------------------------------
>
> Key: COLLECTIONS-759
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-759
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 4.5
> Reporter: Chen Guoping
> Assignee: Bruno P. Kinoshita
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> commons-collections\src\conf\checkstyle.xml
> <module name="NewlineAtEndOfFile">
> <property name="lineSeparator" value="{color:red}lf{color}" />
> </module>
> [The link of
> CI|https://travis-ci.org/github/apache/commons-collections/jobs/672844382]
> {code:java}
> [ERROR] src/main/java/org/apache/commons/collections4/ArrayUtils.java:[1]
> (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.
> [ERROR]
> src/test/java/org/apache/commons/collections4/queue/SynchronizedQueueTest.java:[1]
> (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.
> [ERROR]
> src/test/java/org/apache/commons/collections4/junit/AbstractAvailableLocalesTest.java:[1]
> (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.
> [ERROR]
> src/test/java/org/apache/commons/collections4/junit/SetDefaultLocaleTestRule.java:[1]
> (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.
> [ERROR]
> src/test/java/org/apache/commons/collections4/junit/ObjectToStringComparator.java:[1]
> (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but
> CRLF(\r\n) is detected.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:41 min
> [INFO] Finished at: 2020-04-09T07:11:16Z
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on
> project commons-collections4: You have 5 Checkstyle violations. -> [Help 1]
> {code}
> But I test the checkstyel locally with cmd :
> mvn clean ; mvn checkstyle:checkstyle
> The result is
> Summary
> Files Info Warnings Errors
> 590 0 0 {color:red}590{color}
> Details
> org/apache/commons/collections4/AbstractArrayListTest.java
> Severity Category Rule Message Line
> Error misc {color:red}NewlineAtEndOfFile {color}Expected line
> ending for file is LF(\n), but CRLF(\r\n) is detected. 1
> Can the checkstyle NewlineAtEndOfFile be warning not error ?
> I don't think the checkstyle would affect the used with the software.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
