kinow commented on a change in pull request #518:
URL: https://github.com/apache/commons-lang/pull/518#discussion_r410997660
##########
File path: src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
##########
@@ -810,7 +810,7 @@ public static void removeCommonFrames(final List<String>
causeFrames, final List
* @param <T> the type of Throwable you are searching.
* @param throwable the throwable to inspect, may be null
* @param clazz the class to search for, subclasses do not match, null
returns null
- * @return the index into the throwable chain, null if no match or null
input
+ * @return the first matching throwable form the throwable chain, null if
no match or null input
Review comment:
s/form/from?
##########
File path: src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
##########
@@ -855,7 +855,7 @@ public static void removeCommonFrames(final List<String>
causeFrames, final List
* @param <T> the type of Throwable you are searching.
* @param throwable the throwable to inspect, may be null
* @param type the type to search for, subclasses match, null returns null
- * @return the index into the throwable chain, null if no match or null
input
+ * @return the first matching throwable form the throwable chain, null if
no match or null input
Review comment:
s/form/from?
##########
File path: src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
##########
@@ -835,7 +835,7 @@ public static void removeCommonFrames(final List<String>
causeFrames, final List
* @param clazz the class to search for, subclasses do not match, null
returns null
* @param fromIndex the (zero-based) index of the starting position,
* negative treated as zero, larger than chain size returns null
- * @return the index into the throwable chain, null if no match or null
input
+ * @return the first matching throwable form the throwable chain, null if
no match or null input
Review comment:
s/form/from?
##########
File path: src/main/java/org/apache/commons/lang3/exception/ExceptionUtils.java
##########
@@ -880,7 +880,7 @@ public static void removeCommonFrames(final List<String>
causeFrames, final List
* @param type the type to search for, subclasses match, null returns null
* @param fromIndex the (zero-based) index of the starting position,
* negative treated as zero, larger than chain size returns null
- * @return the index into the throwable chain, null if no match or null
input
+ * @return the first matching throwable form the throwable chain, null if
no match or null input
Review comment:
s/form/from?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
