[
https://issues.apache.org/jira/browse/IO-661?focusedWorklogId=425407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425407
]
ASF GitHub Bot logged work on IO-661:
-------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 18:15
Start Date: 20/Apr/20 18:15
Worklog Time Spent: 10m
Work Description: ferenc-csaky commented on issue #111:
URL: https://github.com/apache/commons-io/pull/111#issuecomment-616725308
The change is not finished, I did not touch the `move` methods yet also.
That parts still throws IOEs and that was the main difference the Jira pointed
out. So my plan is to adapt that part as well. I just wanted to share the
current state if everybody agrees with the direction. Although I should have
been published a comment about it, so sorry for that.
@garydgregory So should I document the exact behaviour changes on the Jira?
@ecki By **this case** you mean the whole context, right? Because the
scenario you mentioned can be applied to all the methods I changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 425407)
Time Spent: 1.5h (was: 1h 20m)
> FileUtils throws inconsistent exceptions
> ----------------------------------------
>
> Key: IO-661
> URL: https://issues.apache.org/jira/browse/IO-661
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.6
> Reporter: Hao Zhong
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The FileUtils throws inconsistent exceptions, when an input is not a
> directory.
> The copyFileToDirectory throws IllegalArgumentException:
>
> {code:java}
> public static void copyFileToDirectory(final File srcFile, final File
> destDir, final boolean preserveFileDate)
> throws IOException {
> if (destDir == null) {
> throw new NullPointerException("Destination must not be null");
> }
> if (destDir.exists() && destDir.isDirectory() == false) {
> throw new IllegalArgumentException("Destination '" + destDir + "'
> is not a directory");
> }
> final File destFile = new File(destDir, srcFile.getName());
> copyFile(srcFile, destFile, preserveFileDate);
> }
> {code}
> The other methods throw IOException:
>
>
> {code:java}
> public static void moveFileToDirectory(final File srcFile, final File
> destDir, final boolean createDestDir)
> throws IOException {
> validateMoveParameters(srcFile, destDir);
> if (!destDir.exists() && createDestDir) {
> destDir.mkdirs();
> }
> if (!destDir.exists()) {
> throw new FileNotFoundException("Destination directory '" +
> destDir +
> "' does not exist [createDestDir=" + createDestDir + "]");
> }
> if (!destDir.isDirectory()) {
> throw new IOException("Destination '" + destDir + "' is not a
> directory");
> }
> moveFile(srcFile, new File(destDir, srcFile.getName()));
> }
> {code}
> I feel that IOException is more reasonable. Although the messages are the
> same, the different exception can cause problems when programmers catch the
> thrown exceptions.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
