[
https://issues.apache.org/jira/browse/COLLECTIONS-757?focusedWorklogId=426569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426569
]
ASF GitHub Bot logged work on COLLECTIONS-757:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/20 15:16
Start Date: 23/Apr/20 15:16
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #146:
URL:
https://github.com/apache/commons-collections/pull/146#discussion_r413886334
##########
File path:
src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
##########
@@ -1287,32 +1287,32 @@ private static void checkKeyAndValue(final Object key,
final Object value) {
}
/**
- * increment the modification count -- used to check for
+ * Increment the modification count -- used to check for
Review comment:
Increment -> Increments
##########
File path:
src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
##########
@@ -1287,32 +1287,32 @@ private static void checkKeyAndValue(final Object key,
final Object value) {
}
/**
- * increment the modification count -- used to check for
+ * Increment the modification count -- used to check for
* concurrent modification of the map through the map and through
- * an Iterator from one of its Set or Collection views
+ * an Iterator from one of its Set or Collection views.
*/
private void modify() {
modifications++;
}
/**
- * bump up the size and note that the map has changed
+ * Bumps up the size and note that the map has changed.
*/
private void grow() {
modify();
nodeCount++;
}
/**
- * decrement the size and note that the map has changed
+ * Decrement the size and note that the map has changed.
Review comment:
Decrement -> Decrements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426569)
Time Spent: 3h 40m (was: 3.5h)
> Some bugs need to fix with JavaDoc in the BidiMap
> -------------------------------------------------
>
> Key: COLLECTIONS-757
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-757
> Project: Commons Collections
> Issue Type: Improvement
> Components: BidiMap
> Reporter: Chen Guoping
> Priority: Major
> Labels: documentation
> Fix For: 4.5
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Some bugs need to fix with JavaDoc in the BidiMap.
> I had provided a PR to fix it.
> [https://github.com/apache/commons-collections/pull/144]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
