[
https://issues.apache.org/jira/browse/COLLECTIONS-758?focusedWorklogId=428542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428542
]
ASF GitHub Bot logged work on COLLECTIONS-758:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/20 12:58
Start Date: 29/Apr/20 12:58
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #113:
URL:
https://github.com/apache/commons-collections/pull/113#discussion_r417293724
##########
File path:
src/test/java/org/apache/commons/collections4/queue/QueueDecoratorTest.java
##########
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.collections4.queue;
+
+import org.apache.commons.collections4.collection.AbstractCollectionTest;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.LinkedList;
+import java.util.Collection;
+import java.util.Queue;
+import java.util.NoSuchElementException;
+
+/**
+ * Test cases for AbstractQueueDecorator.
+ *
+ * @since 4.5
+ */
+public class QueueDecoratorTest<E> extends AbstractCollectionTest<E> {
+ /**
+ * JUnit constructor.
+ *
+ * @param testName the test class name
+ */
+ public QueueDecoratorTest(String testName) {
+ super(testName);
+ }
+
+ @Override
+ public Collection<E> makeConfirmedCollection() {
+ final ArrayList<E> list = new ArrayList<>();
Review comment:
The local var is useless, you can remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 428542)
Remaining Estimate: 0h
Time Spent: 10m
> Add test cases for AbstractQueueDecorator
> -----------------------------------------
>
> Key: COLLECTIONS-758
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-758
> Project: Commons Collections
> Issue Type: Improvement
> Reporter: Chen
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add test cases for AbstractQueueDecorator to improve the code coverage.
> Please give a
> review.[PR:|[https://github.com/apache/commons-collections/pull/113]]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
