aremily commented on a change in pull request #99:
URL: https://github.com/apache/commons-crypto/pull/99#discussion_r418961005
##########
File path:
src/test/java/org/apache/commons/crypto/stream/AbstractCipherStreamTest.java
##########
@@ -294,6 +600,26 @@ protected CryptoOutputStream getCryptoOutputStream(
return new CryptoOutputStream(baos, cipher, bufferSize,
new SecretKeySpec(key, "AES"), new IvParameterSpec(iv));
}
+
+ protected CryptoOutputStream getCryptoOutputStream(final String
transformation,
Review comment:
Unused constructors were a significant gap in code coverage, so it was
an easy win to overload this method and use it to rerun existing tests against
them. Same with the getInputStream, as alluded to in an earlier comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
