GedMarc commented on pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26#issuecomment-623121950
The Jakarta namespace will break a lot of artifacts, everywhere. Especially in running images - What I did was create the default javax and reference the Jakarta as a modular transitive. If you do pull this in now - you will also break all of those. Shading into a private space in your package is fine, but it won't work with servlet 5 - I suggest once Jakarta 9, or even 10, is out (10 is aimed at JDK 8 as well, so don't get stuck waiting for them. Java is moving on, commons libraries should as well). Then do a major version bump, specifying JDK 8 is no longer supported, then bring in the jakarta artifacts, once the java library pool is cleaned out for JDK 9 and above. 2 cents worth - Please also find modular packagings for each of the commons components here (this link is just commons-fileupload but they are all there, except Math), which allows modular builds and JLink/JMod/JPackage imaging. You don't need Jakarta to go/support JDK 9 and up. https://github.com/GedMarc/commons-fileupload ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
