gwlucastrig commented on pull request #72: URL: https://github.com/apache/commons-imaging/pull/72#issuecomment-628694841
I believe that I have now integrated all the changes from the review comments with two exceptions. The TiffRasterData.getData() method still exposes and internal array. However, I've added Javadoc explaining the rationale and use of the method. The Collections.sort() methods in PhotometricInterpreterFloat are still there. When I made the recommended changes, animal-sniffer threw an exception. I then installed Java JDK 11 (picking 11 because that's what Travis uses) and the same thing happened. So I am leaving the older code in place. My plan is to do a bit more testing over the next few days. I do not plan to make any further code changes unless I encounter an unexpected error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
