aherbert commented on a change in pull request #160:
URL:
https://github.com/apache/commons-collections/pull/160#discussion_r425925740
##########
File path:
src/main/java/org/apache/commons/collections4/bloomfilter/BitSetBloomFilter.java
##########
@@ -25,7 +25,7 @@
import org.apache.commons.collections4.bloomfilter.hasher.StaticHasher;
/**
- * A bloom filter using a Java BitSet to track enabled bits. This is a standard
+ * A bloom filter uses a Java BitSet to track enabled bits. This is a standard
Review comment:
Perhaps the grammar should be:
```
A bloom filter **that** uses a Java BitSet
```
Anyway, this is a change totally unrelated to the SimpleBloomFilter in this
PR. So should be reverted.
Since the backing implementation is largely irrelevant (aside from allowing
the determination of memory requirements) a better wording would then be `A
Bloom filter using a fixed size array ...` and the entire class renamed to
ArrayBloomFilter. So this change should be done separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
