elharo commented on a change in pull request #102:
URL: https://github.com/apache/commons-compress/pull/102#discussion_r428316552
##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
##########
@@ -374,6 +374,8 @@ private ZipFile(final SeekableByteChannel channel, final
String archiveName,
}
fillNameMap();
success = true;
+ } catch (IOException e) {
Review comment:
Does archiveName here include the path?
##########
File path: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
##########
@@ -374,6 +374,8 @@ private ZipFile(final SeekableByteChannel channel, final
String archiveName,
}
fillNameMap();
success = true;
+ } catch (IOException e) {
+ throw new IOException("Error on ZipFile " + archiveName +
e.getMessage(), e);
Review comment:
add "; " before `+ e.getMessage()` or drop the message completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
