[
https://issues.apache.org/jira/browse/LANG-1545?focusedWorklogId=437007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437007
]
ASF GitHub Bot logged work on LANG-1545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/20 22:27
Start Date: 24/May/20 22:27
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #529:
URL: https://github.com/apache/commons-lang/pull/529#discussion_r429681039
##########
File path: src/test/java/org/apache/commons/lang3/StringUtilsTest.java
##########
@@ -3301,4 +3301,22 @@ public void testToRootUpperCase() {
Locale.setDefault(defaultLocales);
}
}
+
+ @Test
+ public void testGeorgianSample() {
+ char[] arrayI = new char[]{(char) 305, (char) 1012};
Review comment:
Hi @XenoAmess
Please use hexadecimal for the values with a comment that shows the Unicode
name for each character. Otherwise, there is not way to tell what this is doing
without knowing the Unicode values from memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 437007)
Time Spent: 20m (was: 10m)
> CharSequenceUtils.regionMatches is wrong dealing with Georgian.
> ----------------------------------------------------------------
>
> Key: LANG-1545
> URL: https://issues.apache.org/jira/browse/LANG-1545
> Project: Commons Lang
> Issue Type: Bug
> Reporter: JIN XU
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/529]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
