[ 
https://issues.apache.org/jira/browse/IO-669?focusedWorklogId=439104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439104
 ]

ASF GitHub Bot logged work on IO-669:
-------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/May/20 16:57
            Start Date: 30/May/20 16:57
    Worklog Time Spent: 10m 
      Work Description: XenoAmess commented on a change in pull request #115:
URL: https://github.com/apache/commons-io/pull/115#discussion_r432869943



##########
File path: 
src/test/java/org/apache/commons/io/filefilter/FileFilterTestCase.java
##########
@@ -1406,7 +1406,7 @@ public void testFilterListNullParameters() {
 
         final IOFileFilter filter = FileFilterUtils.trueFileFilter();
         try {
-            FileFilterUtils.filterList(filter, Arrays.asList((File) null));
+            FileFilterUtils.filterList(filter, 
Collections.singletonList((File) null));

Review comment:
       @garydgregory it is only used as a Iterable there thus I think it has no 
actual difference IMO, exluding running speed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 439104)
    Time Spent: 20m  (was: 10m)

> fix code smells; fix typos 
> ---------------------------
>
>                 Key: IO-669
>                 URL: https://issues.apache.org/jira/browse/IO-669
>             Project: Commons IO
>          Issue Type: Improvement
>            Reporter: JIN XU
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/115]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to