jochenw commented on pull request #532:
URL: https://github.com/apache/commons-lang/pull/532#issuecomment-636442299
Hi,
could someone please advise me, what I am doing wring here? Trying to pull
this in:
git clone https://gitbox.apache.org/repos/asf/commons-lang.git
cd commons-lang
git config core.autocrlf true
git remote add github https://github.com/apache/commons-lang.git
git fetch github pull/532:pr/532
git merge pr/532
mvn
....
You have 345 Checkstyle violations.
On Sat, May 30, 2020 at 4:33 PM XenoAmess <[email protected]> wrote:
> Hi.
> commit c141bc9
>
<https://github.com/apache/commons-lang/commit/c141bc961cb5cb84c47a21c3a5b0f15ab0035728>
> broke the Checkstyle, thus making travis-ci cannot pass.
> thus I made a commit to fix it.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/commons-lang/pull/532
> Commit Summary
>
> - reformat Locks and LocksTest for passing Checkstyle
>
> File Changes
>
> - *M* src/main/java/org/apache/commons/lang3/Locks.java
>
<https://github.com/apache/commons-lang/pull/532/files#diff-32fce58470b8035f287da92986131fb4>
> (94)
> - *M* src/test/java/org/apache/commons/lang3/LocksTest.java
>
<https://github.com/apache/commons-lang/pull/532/files#diff-b866a8cd59b73583fe87a4636716a626>
> (95)
>
> Patch Links:
>
> - https://github.com/apache/commons-lang/pull/532.patch
> - https://github.com/apache/commons-lang/pull/532.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-lang/pull/532>, or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAIBUGOQNLTKPXBFG2HAIW3RUEKKNANCNFSM4NOW7JNQ>
> .
>
--
Look, that's why there's rules, understand? So that you think before
you break 'em.
-- (Terry Pratchett, Thief of Time)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
