[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439298
]
ASF GitHub Bot logged work on LANG-1548:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/20 22:26
Start Date: 31/May/20 22:26
Worklog Time Spent: 10m
Work Description: XenoAmess edited a comment on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583
also want to split StringUtils.startswith, endwith, prependIfMissing...
now the call flow is like this:
1. user call startsWith(final CharSequence str, final CharSequence prefix)
2. give an additional boolean, and invoke startsWith(final CharSequence str,
final CharSequence prefix, final boolean ignoreCase)
3. invoke CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0,
prefix.length());
4. in CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0,
prefix.length()) we detect that boolean.
That is, actually weird, as when we call startsWith(final CharSequence str,
final CharSequence prefix) we know the boolean is false, and we still fill a
false boolean and let it detect at runtime.
But, detecting a boolean is not a big performance issue (if not in a loop
and perform tons of times)
So I leave it unchanged for next pr.
We can discuss whether should split regionMatches first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 439298)
Time Spent: 0.5h (was: 20m)
> split regionMatches for better performance
> ------------------------------------------
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: JIN XU
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
