adamretter commented on pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#issuecomment-648746297


   > There is common functionality in Base16/32/64TestData. Base16TestData 
duplicates the DECODE array from Base64TestData and there is the method static 
byte[] streamToBytes(final InputStream is). I prefer your method in 
Base16TestData to stream the InputStream to a byte array. The common 
functionality can be moved into a single class, for example BaseNCodecTestData. 
Opinions on this?
   
   Okay sure... I have pushed a commit which tidies all that up into 
`BaseNTestData.java`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to