garydgregory edited a comment on pull request #530: URL: https://github.com/apache/commons-lang/pull/530#issuecomment-648819474
-1: See below, I will provide an alternate implementation. - The new method makes a copy of the collection as a new array, this can be done without the extra allocation. - The arguments to assertEquals() are backward: The order is (expected, actual). If you do not follow the proper argument order, the failure messages are REALLY confusing ;-) - The new tests do not cover edge cases: -- null array of enums -- empty array of enums -- null list of enums -- empty list of enums ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
