darkma773r commented on a change in pull request #79:
URL: https://github.com/apache/commons-geometry/pull/79#discussion_r445520548
##########
File path:
commons-geometry-core/src/test/java/org/apache/commons/geometry/core/precision/EpsilonDoublePrecisionContextTest.java
##########
@@ -199,13 +199,13 @@ public void testEquals() {
EpsilonDoublePrecisionContext c = new
EpsilonDoublePrecisionContext(1e-6);
// act/assert
- Assert.assertFalse(a.equals(null));
- Assert.assertFalse(a.equals(new Object()));
- Assert.assertFalse(a.equals(b));
- Assert.assertFalse(b.equals(a));
+ Assert.assertNotEquals(null, a);
+ Assert.assertNotEquals(new Object(), a);
Review comment:
JUnit applies its own null checks in the `assertEquals` and
`assertNotEquals` methods, meaning that we end up missing those branches in our
code. This seems to be why the code coverage decreased. Let's revert these
changes on this and all of the other `equals()` method tests and see if the
code coverage goes back up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
