XenoAmess commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650971782
> checks failed because of incompatibility, that is actually no true No it is. you can reproduce by: 0. compile original commons-lang to original-commons-lang.jar 1. create another repo who use original-commons-lang.jar as a lib, named A. 2. compile A into a jar. 3. make sure the A.jar can run correctly with original-commons-lang.jar 4. apply your changes to the codes in commons-lang. 5. compile commons-lang to modified-commons-lang.jar 6. run A.jar with modified-commons-lang.jar I strongly guess it will fail. Varargs is not that convienent, my friend. If you really want a varargs version of that function you can create one, but don't delete the original function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
