aherbert commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651092582
The changes in Hex are not currently complete for a public API. The changes were originally made to allow the Base16 class to use the Hex class. That no longer happens and the changes do not expose all the added functionality. - The `DIGITS_LOWER/UPPER` arrays have been changed to package private although only used by the Hex class. - The `decodeHex` method to decode into a provided `byte[]` is public (OK) - The `encodeHex` methods to encode into a provided array are protected (Not OK). These should be public with the exception of the actual method that does the encoding which should be private, i.e. a public method call can specify offsets and upper/lower case but not actually pass in the toDigits char[]. I would create a new PR for these changes to make it clear they are not related to the Base16 changes. Have you created a ticket on the [codec bugtracker](https://issues.apache.org/jira/projects/CODEC) for this change? If you create one for Base16 and also for Hex changes then the issue number can be added to the change log when merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
