[ 
https://issues.apache.org/jira/browse/LANG-1588?focusedWorklogId=455420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455420
 ]

ASF GitHub Bot logged work on LANG-1588:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jul/20 12:34
            Start Date: 07/Jul/20 12:34
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on pull request #577:
URL: https://github.com/apache/commons-lang/pull/577#issuecomment-654825246


   I do not understand what this PR is about and you'd be correct in assuming 
that I did not parse out the new code in my head or run it in the debugger. 
What are you "refining" here? If you change the algorithm, please use the 
commit comment to explain why implementing this method in this manner is 
better. The commit comment and code comment are only way for anyone looking at 
the code and commit log to make sense of what your intent it is and why it 
happened. TY.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 455420)
    Time Spent: 20m  (was: 10m)

> refine StringUtils.center
> -------------------------
>
>                 Key: LANG-1588
>                 URL: https://issues.apache.org/jira/browse/LANG-1588
>             Project: Commons Lang
>          Issue Type: Sub-task
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/577]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to