sebbASF commented on a change in pull request #9:
URL: https://github.com/apache/commons-parent/pull/9#discussion_r452458794
##########
File path: pom.xml
##########
@@ -898,8 +898,10 @@
<instructions>
<!-- stops the "uses" clauses being added to "Export-Package"
manifest entry -->
<_nouses>true</_nouses>
+ <!-- remove extra headers to improve bit for bit reproducibility
-->
+ <_noextraheaders>true</_noextraheaders>
<!-- Stop the JAVA_1_n_HOME variables from being treated as
headers by Bnd -->
-
<_removeheaders>JAVA_1_3_HOME,JAVA_1_4_HOME,JAVA_1_5_HOME,JAVA_1_6_HOME,JAVA_1_7_HOME,JAVA_1_8_HOME,JAVA_1_9_HOME</_removeheaders>
+
<_removeheaders.commons-parent>JAVA_1_3_HOME,JAVA_1_4_HOME,JAVA_1_5_HOME,JAVA_1_6_HOME,JAVA_1_7_HOME,JAVA_1_8_HOME,JAVA_1_9_HOME</_removeheaders.commons-parent>
Review comment:
I don't understand what _removeheaders.commons-parent is doing?
Why is it necessary to change that line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
