kinow commented on a change in pull request #81:
URL: https://github.com/apache/commons-imaging/pull/81#discussion_r453192870
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoDirectory.java
##########
@@ -16,14 +16,23 @@
*/
package org.apache.commons.imaging.formats.tiff.taginfos;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
import org.apache.commons.imaging.formats.tiff.constants.TiffDirectoryType;
+import org.apache.commons.imaging.formats.tiff.fieldtypes.FieldType;
/**
* A LONG representing an offset to a TIFF directory.
*/
public class TagInfoDirectory extends TagInfoLong {
+
+ static final List<FieldType> fieldList
Review comment:
Let's leave this one `private` until we need to make it public? It
appears to be used only on this class.
##########
File path:
src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadTest.java
##########
@@ -51,4 +60,27 @@ public void test() throws Exception {
}
}
+ @Test
+ public void testReadDirectories() throws Exception {
+ // same as above, but test reading the TIFF directories
+ final List<File> images = getTiffImages();
+ for (final File imageFile : images) {
+ String name = imageFile.getName();
Review comment:
We need to replace the tabs by spaces here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
