garydgregory commented on a change in pull request #124:
URL: https://github.com/apache/commons-io/pull/124#discussion_r455849949



##########
File path: src/test/java/org/apache/commons/io/FileUtilsTestCase.java
##########
@@ -1015,6 +1021,12 @@ public void testIsFileNewerOlder() throws Exception {
 
         final Date date = new Date();

Review comment:
       In general, you want to use hard coded dates in tests in order to avoid 
tests failing on the two times a year the build runs in a locale that happens 
to perform a daylight-saving-time switch. Yes, I've actually seen this happen 
(at work.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to