kinow commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r456853262
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check
spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
Was it because we had too many checkstyle, spotbugs, and javadoc errors,
that it was not worth fixing everything in this PR?
##########
File path: src/test/java/org/apache/commons/graph/spanning/KruskalTestCase.java
##########
@@ -231,6 +232,7 @@ public void verifyNotConnectedMinimumSpanningTree()
* and unit weights.
*/
@Test
+ @Ignore //TODO - for time being ignoring it.
Review comment:
:+1: we just need to review these TODO markers before the first
alpha/RC/or final release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
