[ 
https://issues.apache.org/jira/browse/MATH-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gilles Sadowski updated MATH-1550:
----------------------------------
    Description: 
Class {{SimplexTableau}} is package private and does not seem designed for 
inheritance, but it contains "protected" methods.

There are several instance fields that should preferably be made "final" (for 
thread safety). It seems that to do this, some design changes are necessary 
(a.o. the relationship with {{SimplexSolver}} should be clarified).

 
{{SimplexSolver}} also contains a protected method ({{solvePhase1}}) that is 
not documented for inheritance.
 

  was:
Class {{SimplexSolver}} is package private and does not seem designed for 
inheritance, but it contains "protected" methods.

There are several instance fields that should preferably be made "final" (for 
thread safety).  It seems that to do this, some design changes are necessary 
(a.o. the relationship with {{SimplexSolver}} should be clarified).



> SimplexTableau (linear programming)
> -----------------------------------
>
>                 Key: MATH-1550
>                 URL: https://issues.apache.org/jira/browse/MATH-1550
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.6.1
>            Reporter: Gilles Sadowski
>            Priority: Minor
>              Labels: design
>             Fix For: 4.0, 4.X
>
>
> Class {{SimplexTableau}} is package private and does not seem designed for 
> inheritance, but it contains "protected" methods.
> There are several instance fields that should preferably be made "final" (for 
> thread safety). It seems that to do this, some design changes are necessary 
> (a.o. the relationship with {{SimplexSolver}} should be clarified).
>  
> {{SimplexSolver}} also contains a protected method ({{solvePhase1}}) that is 
> not documented for inheritance.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to