[
https://issues.apache.org/jira/browse/MATH-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161119#comment-17161119
]
Gilles Sadowski commented on MATH-1549:
---------------------------------------
bq. If there is anything I can do to the PR to make it acceptable, I'll be
happy to do it.
Thanks a lot for fixing the issue.
Could you please add the missing Javadoc: All methods (including "private"
ones) must be fully documented. [Unless I'm mistaken, I think that newer
"Commons" components would even fail the build when that's not the case.]
There are also a few nits with the code style:
* space after "for" (in "for" loops),
* one condition per line (in condition checks),
* no "magic" numbers within the methods: "1023" and "10000" must be declared as
"final static" fields,
* opening brace (of method body) on the same line (as the closing parenthesis
of the argument list).
Also the new {{standardize}} method should probably be renamed to better
reflect what it is doing: {{scale}} (?).
> Simplex solver report unbounded solution when solvable constraints scaling up
> -----------------------------------------------------------------------------
>
> Key: MATH-1549
> URL: https://issues.apache.org/jira/browse/MATH-1549
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.6.1
> Environment: macOS catalina
> Reporter: Fan Zhang
> Priority: Major
> Attachments: CommonsMathSimplexSolverTest.java
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *scenario 1:*
> {code:java}
> min: x + y
> x, y >= 0
> 9000x + y >= 0
> 10000x + y >= 2000
> x >= 2{code}
> *scenario 2:*
> {code:java}
> min: x + y
> x, y >= 0
> 9.0E15x + 1.0E12y >= 0
> 1.1e16x + 1.0e12y >= 2.0e15
> 1.0e12x >= 2e12{code}
> for scenario 1, it works out. but for scenario 2 whose constrains are just
> scaled up by 1e12, the solver reports unbounded solution.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
