[ 
https://issues.apache.org/jira/browse/COMPRESS-540?focusedWorklogId=462115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462115
 ]

ASF GitHub Bot logged work on COMPRESS-540:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/20 15:16
            Start Date: 22/Jul/20 15:16
    Worklog Time Spent: 10m 
      Work Description: bodewig commented on pull request #113:
URL: https://github.com/apache/commons-compress/pull/113#issuecomment-662513731


   Unfortunately I've been unable to do a real review so far. $life is just 
setting different priorities right now. A few more or less unsorted thoughts:
   
   * I really wish Compress had abstractions that weren't so tightly bound to 
Java Streams, but we'll likely never find the energy and time to revamp it
   * I understand you want to get feedback on whether something like `TarFile` 
would be accepted rater than the concrete implementation. IMHO this would be a 
nice addition even though I don't expect many people to require random access 
to a raw tar archive. Most people likely deal with tar archives that have been 
compressed and so you'd need to decompress it to a temporary file (or memory) 
for random access.
   * we already have a bunch of things copied from commons-io and our very own 
BoundedInputStream may even predate the one of commons-io. I wouldn't want to 
add a new dependency to 1.x unless the reason was better than avoiding 
dupkiicating a few lines of code.
   * have you considered making `TarArchiveEntry` implement `EntryStreamOffsets 
`?
   * I'd be in favour of moving stream implementations to the utils package, in 
particular if you copy code from the zip package
   * nitpicking: the methods you've moved to `TarUtils` probably don't need to 
be public.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 462115)
    Time Spent: 1.5h  (was: 1h 20m)

> Random access on Tar archive
> ----------------------------
>
>                 Key: COMPRESS-540
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-540
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Robin Schimpf
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The TarArchiveInputStream only provides sequential access. If only a small 
> amount of files from the archive is needed large amount of data in the input 
> stream needs to be skipped.
> Therefore I was working on a implementation to provide random access to 
> TarFiles equal to the ZipFile api. The basic idea behind the implementation 
> is the following
>  * Random access is backed by a SeekableByteChannel
>  * Read all headers of the tar file and save the place to the data of every 
> header
>  * User can request an input stream for any entry in the archive multiple 
> times



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to