garydgregory commented on a change in pull request #42:
URL: https://github.com/apache/commons-dbcp/pull/42#discussion_r463658170
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##########
@@ -597,6 +600,17 @@ public void setPoolStatements(final boolean
poolStatements) {
this.poolStatements = poolStatements;
}
+ /**
+ * Sets wheter the pool of statements (which was enabled with {@link
#setPoolStatements(boolean)}) should
Review comment:
Fix spelling.
##########
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSource.java
##########
@@ -2218,6 +2232,17 @@ public synchronized void setPoolPreparedStatements(final
boolean poolingStatemen
this.poolPreparedStatements = poolingStatements;
}
+ /**
+ * Sets wheter the pool of statements (which was enabled with {@link
#setPoolPreparedStatements(boolean)}) should
Review comment:
Spelling `wheter` -> `whether`.
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
##########
@@ -599,4 +622,20 @@ public synchronized String toString() {
public boolean validateObject(final PStmtKey key, final
PooledObject<DelegatingPreparedStatement> pooledObject) {
return true;
}
+
+ /**
+ * Notification from {@link PoolableConnection} that we returned to the
pool.
+ *
+ * @throws SQLException
Review comment:
Specify _when_ this exception is thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
