sebbASF commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-668293267
The original comparison methods are easy to follow. It would be good to keep the same clarity by defining new versions of BufferedReader that have good single-threaded performance. Such classes would also be useful elsewhere. So for example BufferedReader bufferedInput1 = toBufferedReader(input1); would become something like: FastBufferedReader bufferedInput1 = toFastBuffer(input1) (*) where toFastBuffer() works like buffer() but returns an instance of a non-threadsafe FastBufferedReader. The FastBufferedxxx classes would also be useful in their own right elsewhere in IO. Obviously the documentation would need to make it clear that they are not thread-safe. I suspect they don't need to implement mark (which would make them simpler). (*) FastBuffer is just a suggestion for the name. Maybe QandDBuffer would be better (Quick and Dirty)! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
