[
https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=465956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465956
]
ASF GitHub Bot logged work on IO-670:
-------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/20 23:42
Start Date: 03/Aug/20 23:42
Worklog Time Spent: 10m
Work Description: sebbASF commented on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-668293267
The original comparison methods are easy to follow.
It would be good to keep the same clarity by defining new versions of
BufferedReader that have good single-threaded performance. Such classes would
also be useful elsewhere.
So for example
BufferedReader bufferedInput1 = toBufferedReader(input1);
would become something like:
FastBufferedReader bufferedInput1 = toFastBuffer(input1) (*)
where toFastBuffer() works like buffer() but returns an instance of a
non-threadsafe FastBufferedReader.
The FastBufferedxxx classes would also be useful in their own right
elsewhere in IO.
Obviously the documentation would need to make it clear that they are not
thread-safe.
I suspect they don't need to implement mark (which would make them simpler).
(*) FastBuffer is just a suggestion for the name. Maybe QandDBuffer would be
better (Quick and Dirty)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 465956)
Time Spent: 7h 20m (was: 7h 10m)
> IOUtils.contentEquals is of low performance. I will refine it.
> --------------------------------------------------------------
>
> Key: IO-670
> URL: https://issues.apache.org/jira/browse/IO-670
> Project: Commons IO
> Issue Type: Improvement
> Reporter: Jin Xu
> Priority: Critical
> Attachments: jmh-result.org.apache.json
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-io/pull/118]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
