PeterAlfredLee commented on a change in pull request #93:
URL: https://github.com/apache/commons-vfs/pull/93#discussion_r465428972
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileRandomAccessContent.java
##########
@@ -45,7 +45,7 @@
@Override
public int read() throws IOException {
try {
- return raf.readByte();
+ return raf.readByte() & 0xFF;
Review comment:
Sure.
Seems we need a place to store the constant `0xFF`. IMO we should have a
class to store constants like `0xFF`, which seems is not presented in VFS. What
about adding a `VFSConstants` class in `org.apache.commons.vfs2.util`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
